AMLII-2058 Use correct buffer size for unix sockets #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the client is configured to use UDS via builder's address() method, the client defaulted to UDP-sized buffer. This patch adds a method to the ClientChannel to fetch the default packet size for each transport type, and uses it in the client to pass the correct value to the processor. The maxPacketSizeBytes field of the resolved builder is reduced to only storing the user preferred configuration, if any.
gh123man
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the client is configured to use UDS via builder's address() method, the client defaulted to UDP-sized buffer.
This patch adds a method to the ClientChannel to fetch the default packet size for each transport type, and uses it in the client to pass the correct value to the processor. The maxPacketSizeBytes field of the resolved builder is reduced to only storing the user preferred configuration, if any.